#99 — quills.remoteblogging should not import from zope 2
by
Tim Hicks
—
last modified
Jan 08, 2009 04:35 PM
| State | Resolved |
|---|---|
| Version: | 1.6 |
| Area | Functionality |
| Issue type | Bug |
| Severity | Important |
| Submitted by | Tim Hicks |
| Submitted on | Sep 17, 2007 |
| Responsible | Tim Hicks |
| Target release: | 1.6 |
quills.remoteblogging.browser.metaweblogapi currently does:
import DateTime
which is the zope2 implementation. It should be swapped over to use the standard libraries datetime implementation, instead.
That's easy enough in isolation, but we need to ensure that methods defined in quills.core (with their implementations across quills.app, Products.Quills and Products.QuillsEnabled) are setup to handle datetime arguments rather that DateTime arguments.
import DateTime
which is the zope2 implementation. It should be swapped over to use the standard libraries datetime implementation, instead.
That's easy enough in isolation, but we need to ensure that methods defined in quills.core (with their implementations across quills.app, Products.Quills and Products.QuillsEnabled) are setup to handle datetime arguments rather that DateTime arguments.
Added by
Tom Lazar
on
Sep 17, 2007 06:53 PM
i still haven't found a sane way to convert datetime to DateTime... anysuggestions?
Issue state:
unconfirmed
→
open
Responsible manager:
tim2p
→
tomster
Added by
Tom Lazar
on
Sep 17, 2007 06:58 PM
naro on #plone suggests from Products.ATContentTypes.utils import dt2DT
Issue state:
open
→
in-progress
Added by
Tom Lazar
on
Sep 18, 2007 09:31 PM
this turned out to be non-issue, really. all DateTime was used for, was to construct XML-RPC conform date *strings*, so i could switch that to datetime w/o any side effects. i verified the result manually with ecto and MarsEdit and both worked fine.
Issue state:
in-progress
→
resolved
Added by
Tom Lazar
on
Sep 18, 2007 09:35 PM
ooops, i was too hasty... ironing out some kinks.
Issue state:
resolved
→
open
Added by
Tom Lazar
on
Sep 18, 2007 09:45 PM
ok, properly resolved in r49551
Issue state:
open
→
resolved
i finally remembered, that it was just a hack (that i introduced myself at the time) that provided a workaround for a temporary implementation weirdness in Zope 2.9's xmlrpc lib. that workaround included a dependency on DateTime, now (with Zope 2.10) we can just pass the value from xmlrpc lib unchanged and thus avoid any explicit dependency on DateTime.
Added by
Tom Lazar
on
Sep 18, 2007 09:48 PM
@tim2p btw by accident i included another fix in rr49551 that i had meant to commit separately.
Responsible manager:
tomster
→
tim2p
(see http://dev.plone.org/collective/changeset/49551)
if you feel the need to discuss those changes, please re-open this ticket.
No responses can be added.
If you can, please log in before submitting a reaction.
