#194 — quills.app breaks non-quills commenting
by
FairSay
—
last modified
May 19, 2009 01:55 PM
| State | Tested and confirmed closed |
|---|---|
| Version: | 1.7 |
| Area | Process |
| Issue type | Bug |
| Severity | Critical |
| Submitted by | FairSay |
| Submitted on | May 19, 2009 |
| Responsible | Jan Hackel |
| Target release: | 1.7 |
It seems quills.app breaks non-Quills commenting.
When I try to leave a comment on a non-quillsEnabled content-type (I tried a document type), I get the error: "NameError: global name 'redirect_target' is not defined" (traceback below). When I try and do the same thign on a QuillsEnabled content item, it works fine.
I use qPloneComments to easily enable and manage non-authenticated commenting and this error occurs both when trying to post a comment as anonymous and authenticated users. I tried both 3.2.3 (final) and 4.0.1 beta and the issue occurs with both. The traceback seems to indicate it is a Quills.app issue though:
Traceback (innermost last):
Module ZPublisher.Publish, line 119, in publish
Module ZPublisher.mapply, line 88, in mapply
Module ZPublisher.Publish, line 42, in call_object
Module Products.CMFFormController.FSControllerPageTemplate, line 90, in __call__
Module Products.CMFFormController.BaseControllerPageTemplate, line 28, in _call
Module Products.CMFFormController.ControllerBase, line 231, in getNext
Module Products.CMFFormController.Actions.TraverseTo, line 38, in __call__
Module ZPublisher.mapply, line 88, in mapply
Module ZPublisher.Publish, line 42, in call_object
Module quills.app.browser.discussionreply, line 72, in __call__
NameError: global name 'redirect_target' is not defined
When I try to leave a comment on a non-quillsEnabled content-type (I tried a document type), I get the error: "NameError: global name 'redirect_target' is not defined" (traceback below). When I try and do the same thign on a QuillsEnabled content item, it works fine.
I use qPloneComments to easily enable and manage non-authenticated commenting and this error occurs both when trying to post a comment as anonymous and authenticated users. I tried both 3.2.3 (final) and 4.0.1 beta and the issue occurs with both. The traceback seems to indicate it is a Quills.app issue though:
Traceback (innermost last):
Module ZPublisher.Publish, line 119, in publish
Module ZPublisher.mapply, line 88, in mapply
Module ZPublisher.Publish, line 42, in call_object
Module Products.CMFFormController.FSControllerPageTemplate, line 90, in __call__
Module Products.CMFFormController.BaseControllerPageTemplate, line 28, in _call
Module Products.CMFFormController.ControllerBase, line 231, in getNext
Module Products.CMFFormController.Actions.TraverseTo, line 38, in __call__
Module ZPublisher.mapply, line 88, in mapply
Module ZPublisher.Publish, line 42, in call_object
Module quills.app.browser.discussionreply, line 72, in __call__
NameError: global name 'redirect_target' is not defined
- Steps to reproduce:
- 1) Enable commenting on a non-Quills 'document' item
2) Try and add a comment. (qPloneComments may or may not be necessary)
3) The error shouold have been raised when 'saving' the comment
Added by
FairSay
on
May 19, 2009 11:16 AM
Forgot: I am using QuillsEnabled 1.7rc1 installed via an egg in a buildout.
Added by
Jan Hackel
on
May 19, 2009 01:04 PM
There is now a test-case at r86414 (http://dev.plone.org/collective/changeset/86414).
Severity:
Medium
→
Critical
Responsible manager:
(UNASSIGNED)
→
jhackel
Target release:
None
→
1.7
Added by
Jan Hackel
on
May 19, 2009 01:22 PM
There is now a fix at r86416 (http://dev.plone.org/collective/changeset/86416). A new version of egg `quills.app` has also been released.
Issue state:
Unconfirmed
→
Resolved
Added by
FairSay
on
May 19, 2009 01:55 PM
I've updated my quills.app installation from SVN and tested it with both anonymous and authenticated cases and it works perfectly.
Issue state:
Resolved
→
Tested and confirmed closed
Well done Jan - I'll see what other critical bugs I can find :-)
No responses can be added.
If you can, please log in before submitting a reaction.
