#189 — Replying to an comment raises a non-fatal TypeError during portlet rendering

by Jan Hackel — last modified May 08, 2009 09:39 AM

State	Resolved
Version:	1.7
Area	Functionality
Issue type	Bug
Severity	Low
Submitted by	Jan Hackel
Submitted on	Apr 27, 2009
Responsible	Jan Hackel
Target release:	1.7

Return to tracker

Giving answer to a comment on a weblog post will result in a TypeError ('Could not adapt', <DiscussionItem at .../plone/quills/entry/talkback/1240861693>, <InterfaceClass quills.core.interfaces.weblog.IWeblogLocator>). See the attachment for full trace-back.

This affects both Quills and QuillsEnabled. Seen with svn/trunk post 1.7.0b3.

Steps to reproduce:: Create a weblog containing a post. Enable commenting for that post. Add a comment to that post. Reply to that comment you made.

Attached:

traceback.zip — ZIP archive, 905 bytes

Added by Jan Hackel on Apr 28, 2009 03:17 PM

Issue state: Unconfirmed → Resolved

Responsible manager: (UNASSIGNED) → jhackel

Test-case and fix now at rev 85157 (http://dev.plone.org/collective/changeset/85157).

This issue arose because Quills' portlets were trying to locate the weblog by an IWeblogLocator adapter. While the default implementation for this adapter works for
discussion items too, it was not registered for them.

Added by Jan Hackel on May 08, 2009 09:39 AM

There is now a more generalized solution at rev. 85687 (http://dev.plone.org/collective/changeset/85687). As it turned out the uploads and topic image folder and everything in them caused the same problem.

No responses can be added.