#181 — Opting to use a news item instead of a Document for the blog entry type doesn't work

by FairSay last modified Aug 21, 2009 03:31 AM
State Confirmed
Version: 1.7
Area Functionality
Issue type Feature
Severity Medium
Submitted by FairSay
Submitted on Apr 21, 2009
Responsible
Target release: 2.0
The Quills 'Configure Blog' screen has an option to set the 'Default type' (portal_type) to something other than Document (e.g. News Item).

When this change is made and a content type (News Item) of the selected type is added and published, the selected content type (News Item) does not list the blog entries.

This was tested using QuillsEnabled 1.7.0 b2
Steps to reproduce:
1) Go to the ''Configure Blog'' screen
2) Set 'Default type' to 'News Item' (or other conent type)
3) Add new blog post of new content type
4) Publish new blog post
5) List the blog entries

The new entriy does not appear.
Added by Jan Hackel on Apr 23, 2009 08:37 AM
Issue state: UnconfirmedConfirmed
Target release: None2.0
Only the document type adapters are currently implemented. All the others should be no big deal though. However, they will not make it into 1.7.

So this is more a feature request.
Added by Tim Hicks on Apr 24, 2009 03:25 PM
Ah, I'm probably the source of this minor confusion. When I wrote the config screens, I thought that someone had already checked-in code that implemented the adapter for News Items. Looking now, I can't find it.

Agree that this is a feature request (and arguably a very minor bug that the config option is displayed when it serves no purpose). It should be very easy to implement, though, as I expect the News Item adapter would look a *lot* like the Document adapter. I wouldn't be surprised if it worked without change, in fact.
Added by FairSay on Apr 27, 2009 09:52 AM
Tim and Jan,

Makes sense this is a feature request then - all I know is a feature was there that didn't work and I wasn't sure if it once had or hasn't been implemented.

Added by Jan Hackel on May 05, 2009 09:53 AM
After reading Jon Stahl's report on using Scrawl entry types with QuillsEnabled (http://blogs.onenw.org/[…]/), I gave this a try. It works with svn/trunk. It *should* work with beta2 as the change was made prior to that release (http://dev.plone.org/collective/changeset/74326).
Added by FairSay on May 05, 2009 10:32 AM
I can also confirm that using 'News item' as the Quills default type work (tested with svn trunk of QuillsEnabled and thus likely b3 and possibly b2. I may have been using b1 when I first identified this issue)

What I tested was:
1) Changing the default content type for a QuillsEnabled blog to 'News Item'
2) Adding a new blog entry (now 'News Item') via the Quills admin portlet
3) Publishing that blog entry
4) Confirmed it displayed in the blog view

What I also noticed is all my existing 'Document' based blog entries still displayed with the new 'News Item'. This means switching from one using content type to another 'mid-blog' is possible without losing old entries.

I was unaware of this issues being resolved in svn with change http://dev.plone.org/collective/changeset/74326 since it wasn't reflected in a ticket...so glad it seems solved!
Added by Jan Hackel on May 05, 2009 01:16 PM
The default content type setting merely controls which portal type the admin portlet (and the API) will create. It is intentional that a blog can contain posts of various types!

Still leaving this open to remind us to include the Event type as well.
Added by FairSay on May 06, 2009 09:59 AM
I've just tried adding an event type by adapting the changes used in http://dev.plone.org/collective/changeset/74326. Everything seems to work well except the atom feed which produces an 'AttributeError: CookedBody' related to fatsyndication (trackback below).

I'll leave it to others to figure out what it means and I'll keep my hand away from programming and focus on testing :-)

Traceback (innermost last):
  Module ZPublisher.Publish, line 119, in publish
  Module ZPublisher.mapply, line 88, in mapply
  Module ZPublisher.Publish, line 42, in call_object
  Module Products.fatsyndication.browser.feed, line 55, in atom
  Module Shared.DC.Scripts.Bindings, line 313, in __call__
  Module Shared.DC.Scripts.Bindings, line 350, in _bindAndExec
  Module Products.PageTemplates.PageTemplateFile, line 129, in _exec
  Module Products.CacheSetup.patch_cmf, line 74, in PT_pt_render
  Module Products.CacheSetup.patch_utils, line 9, in call_pattern
  Module Products.PageTemplates.PageTemplate, line 98, in pt_render
  Module zope.pagetemplate.pagetemplate, line 117, in pt_render
  Module zope.tal.talinterpreter, line 271, in __call__
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 824, in do_loop_tal
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 536, in do_optTag_tal
  Module zope.tal.talinterpreter, line 521, in do_optTag
  Module zope.tal.talinterpreter, line 516, in no_tag
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 586, in do_setLocal_tal
  Module zope.tales.tales, line 696, in evaluate
   - URL: atom.xml
   - Line 107, Column 6
   - Expression: <PythonExpr (len(feedentry.getBody()) > 0)>
   - Names:
      {'container': <quills.app.syndication.WeblogFeed object at 0x1201b96c>,
       'context': <quills.app.syndication.WeblogFeed object at 0x1201b96c>,
       'default': <object object at 0xb7ea4528>,
       'here': <quills.app.syndication.WeblogFeed object at 0x1201b96c>,
       'loop': {'feedentry': <Products.PageTemplates.Expressions.PathIterator object at 0x1216a6cc>},
       'nothing': None,
       'options': {'args': ()},
       'repeat': <Products.PageTemplates.Expressions.SafeMapping object at 0x130fe78c>,
       'request': <HTTPRequest, URL=http://www.fairsay.com/blog/atom.xml/atom>,
       'root': <Application at >,
       'template': <ImplicitAcquirerWrapper object at 0x1313310c>,
       'traverse_subpath': [],
       'user': <PropertiedUser 'duane'>,
       'view': <UnauthorizedBinding: context>,
       'views': <zope.app.pagetemplate.viewpagetemplatefile.ViewMapper object at 0x130fe88c>}
  Module zope.tales.pythonexpr, line 59, in __call__
   - __traceback_info__: (len(feedentry.getBody()) > 0)
  Module <string>, line 0, in ?
  Module Products.fatsyndication.adapters.feedentry, line 110, in getBody
AttributeError: CookedBody
Added by FairSay on May 12, 2009 01:51 PM
One standard 'feature' of news items that doesn't yet work with a QuillsEnabled post as a News items is that the image that is associated with a news items doesn't display in the blog-summary view when the 'Only excerpt in weblog view.' option is selected (and doesn't when it is not selected, but that would be undersirable)

In a normal folder, selecting the 'Summary View' allows a listing of content similar to a blog-view (without the commennt count, tags, author, etc). When this items is a news item, it also displays the associated image to the left of the summary.

However if this folder is activated as a blog (via QuillsEnabled), the image of the news item doesn't display next to the summary view (with Only excerpt in weblog view. enabled).

When the "Only excerpt in weblog view" option is not selected, this is not relevent since the 'full' view of a news item doesn't display it's associated image anyway.

(note: should this be a separate issue or a detail of this issue)?
Added by (anonymous) on Aug 17, 2009 04:40 PM
2tX87k <a href="http://bspwgsqlsdww.com/">bspwgsqlsdww</a>, [url=http://bgzldzdgpghm.com/]bgzldzdgpghm[/url], [link=http://lchbbdadyzkq.com/]lchbbdadyzkq[/link], http://nicvvhterzys.com/
Added by (anonymous) on Aug 20, 2009 06:56 PM
#1" rel="nofollow">http://www.kaboodle.com/levitra1#1 generic levitra, =-[,
Added by (anonymous) on Aug 21, 2009 03:31 AM
#1" rel="nofollow">http://www.kaboodle.com/femaleviagra#1 Female Viagra, 926953401456,

No responses can be added.

Filed under: