#119 — Add comment form doesn't respect weblog archive URLs

by Tim Hicks — last modified Feb 12, 2010 10:19 AM
State Resolved
Version: 1.6
Area Functionality
Issue type Bug
Severity Medium
Submitted by Tim Hicks
Submitted on Oct 28, 2007
Responsible
—
Target release: 1.7
Return to tracker
Tags:
Clicking the 'Add Comment' button on a weblog entry takes you to a URL like:

  http://localhost:8080/[…]/discussion_reply_form

It should take you to a URL like:

  http://localhost:8080/[…]/discussion_reply_form

as this stops users from getting into a trail of URLs that is not archive-aware.
Added by Jan Hackel on Nov 05, 2008 09:09 AM
Issue state: unconfirmed → open
Target release: 1.6 → 2.0
Confirmed. Still there in 1.7. It is releated to issue #120, I suppose.
Added by Tim Hicks on Dec 16, 2008 08:49 PM
I had a quick look at this while working on #120. It seems harder to fix as the template at plone/app/layout/viewlets/comments.pt has hard-coded calls to [comment_object].absolute_url() when it generates the URLS and it's not easy to override this in a sane way.
Added by Tim Hicks on Jan 09, 2009 12:33 PM
See http://dev.plone.org/collective/changeset/78681. I over-ride the tail end of the discussion_reply_form form-controller sequence (i.e. the discussion_reply skin script). This allows me to redirect back to the appropriate weblog-archive url. When commenting, users still visit the non-archive url, but they then get back to the correct view afterwards. Not ideal, but probably good enough.

N.B. No tests are included as a deficiency in zope.testbrowser seems to be stopping us from having browser tests that work for urls with anchors at the end (e.g. foo/bar#baz) - which is precisely what the comment machinery generates.

As a side note, the commenting machinery used by plone is *not* very developer-friendly!
Added by Tim Hicks on Jan 09, 2009 01:09 PM
Issue state: Confirmed → Resolved
Now added this to Products.Quills, as well: http://dev.plone.org/collective/changeset/78685.
Added by Jan Hackel on Feb 17, 2009 01:29 PM
Issue state: Resolved → Confirmed
Target release: 2.0 → 1.7
At least for Plone 3.2 this feature is not in effect. Later today I will check if it is broken for 3.1 as well. We need a functional test for this one, it seems prone to regression.
Added by (anonymous) on Mar 19, 2009 11:41 PM
are they coming out with another version soon. I want the people at our parent company to start using the new Plone that I keep hearing about. They are at http://menexis.com
Added by Jan Hackel on Apr 28, 2009 12:30 PM
Issue state: Confirmed → Resolved
I don't know what I saw in February, but now this seems to work correctly. I committed a test-case at rev. 85149 (http://dev.plone.org/collective/changeset/85149).

At least up to Plone 3.2.2 this test-case cannot finnish correctly though, because of a bug in the packages zope.testbrowser and mechanize. They will send the URL fragment to the server which will choke on it. Recent versions of those packages have fixed that. God knows which Zope release will ship them, though.
Added by (anonymous) on Aug 11, 2009 05:32 PM
comment1, http://multilang.hostbeat.co.uk/yonkeerson.html day, >:-[[, http://woxas.977mb.com/heescas.html gifford, 27050,
Added by (anonymous) on Aug 16, 2009 06:25 PM
comment4, http://www.prackiza.home.ro/vay.html f, 8D,

No responses can be added.