#4 — ImageEditor problems with IE 6 and 7
by
Jeff Kunce
—
last modified
Feb 15, 2010 11:27 AM
| State | Resolved |
|---|---|
| Version: | 1.2rc3 |
| Area | User interface |
| Issue type | Bug |
| Severity | Medium |
| Submitted by | Jeff Kunce |
| Submitted on | Feb 14, 2010 |
| Responsible | Nathan Van Gheem |
| Target release: |
—
|
Clicking the imageeditor tab in IE6/IE7 does not bring up edit dialogs. A javascript error is flagged:
IE7 Runtime error Line 12, Invalid Argument
++resource++jquery-1.3.2.min.js
This error is described well at: http://www.n8williams.com/d[…]time-error-invalid-argument
The CSS fixes described do not work. The suggested patches to jQuery work, but the image window that comes up in IE is very small. Patching jQuery is not a good solution, anyway :)
It turns out that ImageEditor uses window.innerWidth and window.innerHeight which are not supported by IE. I've attached a patch adapted from: http://www.webdeveloper.com/[…]/t-116875.html
The patch uses clientWidth and clientHeight if innerWidth and innerHeight are not defined. Other posts on the web point out that this is not the best solution, and can have side-effects. However, it works for my needs.
The patch attached is for alagimp.js - a very similar change can be made to imageeditor.js but only alagimp.js appears to be used on my system.
This is a great product - Thanks!
IE7 Runtime error Line 12, Invalid Argument
++resource++jquery-1.3.2.min.js
This error is described well at: http://www.n8williams.com/d[…]time-error-invalid-argument
The CSS fixes described do not work. The suggested patches to jQuery work, but the image window that comes up in IE is very small. Patching jQuery is not a good solution, anyway :)
It turns out that ImageEditor uses window.innerWidth and window.innerHeight which are not supported by IE. I've attached a patch adapted from: http://www.webdeveloper.com/[…]/t-116875.html
The patch uses clientWidth and clientHeight if innerWidth and innerHeight are not defined. Other posts on the web point out that this is not the best solution, and can have side-effects. However, it works for my needs.
The patch attached is for alagimp.js - a very similar change can be made to imageeditor.js but only alagimp.js appears to be used on my system.
This is a great product - Thanks!
Added by
Nathan Van Gheem
on
Feb 14, 2010 01:55 AM
Wow, great work. I appreciate it greatly. I will try and get a new release out before Monday. Thanks.
Issue state:
Unconfirmed
→
Confirmed
Responsible manager:
(UNASSIGNED)
→
vangheem
Added by
Nathan Van Gheem
on
Feb 15, 2010 11:27 AM
Fixed in svn.
Issue state:
Confirmed
→
Resolved
No responses can be added.
If you can, please log in before submitting a reaction.

ImageEditor_browser_resources_alagimp_js_ie_fix.diff