#213 — Sending mail fails when users don't have email addresses
| State | Resolved |
|---|---|
| Version: | 1.2 |
| Area | Functionality |
| Issue type | Bug |
| Severity | Medium |
| Submitted by | (anonymous) |
| Submitted on | Apr 07, 2009 |
| Responsible | Maurits van Rees |
| Target release: | 1.2 |
Last modified on
Apr 15, 2009
by
Maurits van Rees
When an email is going to be sent (eg when a new issue is created), Poi's send mail code fails (understandably) when a user is specified as a manager for the Issue Tracker, but that user's email address is blank.
This might be the case when you have an admin user or if the user properties are coming from something like LDAP and a user doesn't have an email.
Simple fix:
In content/PoiTracker.py:
Line 428
+ if address is '':
+ continue
Might also want to consider the possibility that the user's email address is malformed. Having a bad email address would probably cause the underlying code to fail as well and the exception handler won't help us.
This might be the case when you have an admin user or if the user properties are coming from something like LDAP and a user doesn't have an email.
Simple fix:
In content/PoiTracker.py:
Line 428
+ if address is '':
+ continue
Might also want to consider the possibility that the user's email address is malformed. Having a bad email address would probably cause the underlying code to fail as well and the exception handler won't help us.
- Steps to reproduce:
- Create Issue Tracker
Add a user without an email address as a manager
Create a new issue as another user
Email tries to get sent, and fails because it's going to a blank address.
Added byMaurits van ReesonApr 15, 2009 10:21 PM
Good point. Fixed on trunk in r84286.
Issue state:
Unconfirmed
→
Resolved
Responsible manager:
(UNASSIGNED)
→
maurits
Target release:
None
→
1.2
No responses can be added.
If you can, please log in before submitting a reaction.