#139 — removing all area rows -> unable to select area -> unable to create issue

by Per Erik Strandberg — last modified Jan 05, 2009 09:30 AM

State	Resolved
Version:	—
Area	User interface
Issue type	Bug
Severity	Medium
Submitted by	Per Erik Strandberg
Submitted on	Aug 14, 2007
Responsible	Maurits van Rees
Target release:	1.1

Return to tracker

At least under Poi 1.0rc2 svn/unreleased build 2 an admin can remove all area rows and still have a valid saveable poi-tracker. It is now impossible to create issues since an issue seems to require (at least) one area.

Suggestion: make it impossible to delete the last area row, or make it impossible to save the tracker without at least one row.

/Per

Steps to reproduce:: From your present issue tracker goto edit.
Under area press the red cross to delete all rows.
Press save at the bottom.
(Try to) [C|c]reate a new issue.
You should see somethink like on the screenshot (without my text).

Attached:

poi_screenshot_firefox_20070814_133210.png — PNG image, 57 kB (59216 bytes)

Added by Maurits van Rees on Nov 16, 2007 11:55 PM

Issue state: unconfirmed → open

Target release: None → 1.1

Responsible manager: (UNASSIGNED) → maurits

Confirmed. Both DataGridFields of a PoiTracker (availableAreas and availableIssueTypes) are required. But when adding/editing them through the web a hidden entry is always submitted so the basic test for required fields is not enough.

I tried adding an own validator. I made unit tests and integration tests (checking if my validator was correctly registered) and these all pass. But in practice I get a warning on Zope startup that makes it not work:
WARNING: Disabling validation for availableIssueTypes: minLen1

I made a branch for it here in case anyone is interested:
http://dev.plone.org/[…]/maurits-minlen1-validator

But that branch can be forgotten really, as by now I have it working with an ExpressionValidator. I am writing tests for it now.

Added by Maurits van Rees on Nov 17, 2007 12:05 AM

Issue state: open → resolved

Fixed on trunk in r54007.

Added by Maurits van Rees on Dec 22, 2007 01:53 AM

Note: this fix introduced a problem, but this has meanwhile been solved. See #160 for details.

No responses can be added.