Personal tools
You are here: Home → Products → Plone → Roadmap → #94: Replace IndexIterator with a generator
Navigation
Log in


Forgot your password?
New user?
 
Document Actions

#94: Replace IndexIterator with a generator

Contents
  1. Motivation
  2. Assumptions
  3. Proposal
  4. Implementation
  5. Deliverables
  6. Risks
  7. Progress log
by Whit Morriss — last modified June 11, 2006 - 00:22
Replace tabindex iterator class with method on the PloneTool that returns a generator. Remove klugdy 'import' statements from zpts and make calls to the PloneTool to get said generator.
Proposed by
D. Whit Morriss
Seconded by
Christian 'Tiran' Heimes
Proposal type
User interface, Architecture
Repository branch
2.1-tabindex-removal
State
rejected

Motivation

The fate of tabindexes are up for debate, but the current method of kludging a import from Products.CMFPlone into a zpt is an ugly hack that makes Plone's skins incompatible with Zope 2.8's z3 views

Replacing this hack with a method on the PloneTool that return a configurable iterator allows for gentle backward compatibility, a small bump in performance, and the use of z3 views.

Assumptions

Complete removal of tabindexes is not dealt with here.

Proposal

same as summary

Implementation

Plone: Add getTabIndexIterator to PloneTool[done].
replace all calls to IndexIterator with calls to PloneTool[done]

AT: removal of all IndexIterator calls, additon of getTabIndexIterator to ATTool

Deliverables

Unit tests for new methods on ATTool and PloneTool

Risks

anyone who has called IndexIterator in the old fashion from a template will experience breakage

Progress log

branch on plone is done.

need to submit patch to AT

For any issues with the web site functionality, please file a ticket.

Please consult the policy on plone.org content if you want your content published on this site.

Servers and hosting by