Personal tools
You are here: Home Products Plone Roadmap #196: GroupUserFolder removing
Document Actions

#196: GroupUserFolder removing

Contents
  1. Definitions
  2. Motivation
  3. Assumptions
  4. Proposal
  5. Implementation
  6. Deliverables
  7. Risks
  8. Progress log
  9. Participants
by Encolpe Degoute last modified December 11, 2007 - 22:46
Since PAS implementation, users and groups UI keep a lot of GroupUserFolder references that are broken. This PLIP should remove entirely any reference to GroupUserFolder and fix all UI bugs around it.
Proposed by
Encolpe Degoute
Proposal type
User interface
State
being-discussed

Definitions

 

Motivation

There were and there are a lot of critical UI bugs around GroupUserFolder by PlonePAS. Because of these, several Plone release had to be delayed. We fix a lot of them in customer branch.

Assumptions

 

Proposal

The first point is to fix UI to use pure PlonePAS API:

  1. users and groups control panel
  2. members search form
  3. sharing tab

 

Then we can cover all these by some functional doctests to prepare GroupUserFolder removing.

 

To remove GroupUserFolder we need to replace 4 tools:

  1. portal_membership (yet done)
  2. portal_memberdata (yet done)
  3. portal_groups (to do)
  4. portal_groupdata (to do)

 

As PluggableAuthService and PlonePAS implements all we need, it's more a compatibility step we need to put a depreciation warning on these tools. The removing step should implements an utility that assemble all methods from historical tools and put a deprecation warning tools usage.

 

Implementation

Groups are already implemented in PlonePAS, then we have to give them a group property sheet based on user property sheet.

UI improvements are already deployed  in a private branch.

Deliverables

 

Risks

GroupUserFolder is unusable since two major versions. There is no risk to remove it.

But, implementing a new portal_groups and portal_groupdata would preserve the same API and run the same tests. This could give some headache.

The

Progress log

 

Participants

 

Framework team vote

Posted by Andreas Zeidler at December 13, 2007 - 23:19
+1 on cleaning up and fixing broken links, but -1 on replacing existing tools (see http://lists.plone.org/pipermail/framework-team/2007-December/001507.html)

Framework team vote

Posted by Tom Lazar at December 20, 2007 - 13:01
I second this.

Framework team vote

Posted by Raphael Ritz at December 20, 2007 - 08:15
+1 on cleaning up the UI and making it use the proper API but -1 on tool removal/change. I would consider that OK for Plone 4.0 but not for 3.1.
Introducing deprecation warnings, however, could be considered OK.

BTW: I'm somewhat confused here myself because as pointed out in the PLIP the GroupUserFolder isn't usable since a while anyway but I simply don't know whether it could be considered safe for removal is I cannot judge whether anything still might bepend on it (most notably 3rd-party add-ons which we have promised not to break in this release).

Framework vote

Posted by Martijn Pieters at December 21, 2007 - 17:04
Another +1 on the UI cleanups and -1 on the risky tool removals.

Framework team vote

Posted by Danny Bloemendaal at December 22, 2007 - 16:14
+1 on UI cleanups

UI Cleanups

Posted by Encolpe Degoute at December 23, 2007 - 18:17
They are ready to be commited.
Do you prefer I do this in the trunk or in a bundle ?

For any issues with the web site functionality, please file a ticket.

Please consult the policy on plone.org content if you want your content published on this site.

Servers and hosting by