#4 — index_html vs. download in conjuction with pdf anchors

In current trunk (rev22526) of content.py the index_html method always returns the results of field.download(..) for file content. As a result, files are never displayed "inline" because the Content-disposition gets set to "attachement".

    def index_html(self, REQUEST, RESPONSE):
        """ download the file inline or as an attachment """
        field = self.getPrimaryField()
        if IATBlobImage.providedBy(self):
            return field.index_html(self, REQUEST, RESPONSE)
        else:
            return field.download(self, REQUEST, RESPONSE)


If inline display is wanted for some reason (e.g. pdf anchors work only if pdf is displayed inline), it works with ATContentType File, but doesn't work with ATBlob.


ATContentTypes (version shipped with Plone 3.1) handle this in content/file.py line 107ff by checking, if the content_type is in a list of "inlineMimetypes". If so, it returns index_html(..), download(..) otherwise.


Would it be possible to keep that feature? The following patch re-adds the behavior:



from Products.ATContentTypes.content.file import ATFile
...
def index_html(self, REQUEST, RESPONSE):
    """ download the file inline """
    field = self.getPrimaryField()
    if field.getContentType(self) in ATFile.inlineMimetypes:
        # return the PDF and Office file formats inline
        return field.index_html(self, REQUEST, RESPONSE)
    return field.download(self, REQUEST, RESPONSE)