#40 — galleryview shows images of main gallery as random image of subgalleries

by Harald Friessnegger — last modified Jul 29, 2010 08:33 AM
State Tested and confirmed closed
Version: 0.9.1rc3
Area Functionality
Issue type Bug
Severity Medium
Submitted by Harald Friessnegger
Submitted on Jul 28, 2010
Responsible Nathan Van Gheem
Target release:
—
Return to tracker
the random image of a subgallery is not shown for basic galleries since 0.9.1rc3.

the changes made in http://dev.plone.org/collective/changeset/119602 make cooked_images memoize the value of retrieve_images.

the use of memoize.view results in the value of the gallery itself beeing cached even for the subgalleries.

in my case the gallery itself was empty, so there was no thumb for the subgalleries at all.
if the gallery contains images those are used as thumbs for the subgallery which is not what we want neither.

i changed the import to use plone.memoize.instance instead of memoize.view which should fix this issue
Added by Harald Friessnegger on Jul 28, 2010 12:46 PM
should be fixed with http://dev.plone.org/collective/changeset/122147
Added by Nathan Van Gheem on Jul 28, 2010 12:57 PM
Issue state: Unconfirmed → Confirmed
Responsible manager: (UNASSIGNED) → vangheem
Just missed this for the release. I'll do another release tonight to address it.

Unless you want privs to make the release?
Added by Harald Friessnegger on Jul 28, 2010 03:12 PM
adding me as a maintainer on pypi would be great (user: frisi) however, the plone.org releases can only be done by the owner of the product section :-(
Added by Nathan Van Gheem on Jul 28, 2010 03:16 PM
Alright, I gave you rights on pypi and I shared the plone.org page with you.

I think you are able to make a release on plone.org also with sharing as I think I've done that before.


Thanks!
Added by Nathan Van Gheem on Jul 28, 2010 03:18 PM
BTW, I already made a 1.0rc1 release so you'll need to move those entries in the changelog to a 1.0rc2 release.
Added by Nathan Van Gheem on Jul 29, 2010 08:21 AM
Issue state: Confirmed → Resolved
Added by Harald Friessnegger on Jul 29, 2010 08:33 AM
Issue state: Resolved → Tested and confirmed closed
works with 1.0rc2

No responses can be added.