#23 — Broken with plone.app.imaging trunk (>1.0b8)

by Harald Friessnegger — last modified Apr 20, 2010 03:13 PM

State	Tested and confirmed closed
Version:	0.8.2b3
Area	Functionality
Issue type	Bug
Severity	Medium
Submitted by	Harald Friessnegger
Submitted on	Mar 31, 2010
Responsible	Nathan Van Gheem
Target release:	—

Return to tracker

current trunk (rev 113984) and also prev releases won't start up with plone.app.imaging >1.0b8 (currently only trunk version)

reason:

plone.app.imaging patches the sizes property of the imagefield to allow setting sizes in the control panel and on custom fields.
see http://dev.plone.org/plone/ticket/10159 for the current discussion on how this will be implemented.

galleryadapters.basic reads sizes from ATImageSchema and expects ATImageSchema['image'].sizes['large'] and tile to be available. atm sizes is None, which leads to an error.

solution:
i don't get the point why this adapter is using custom sizes for small and medium but atimage size definitions for large and thumb...
could you please explain to me?

maybe sizes won't be none in future releases of p.a.i (follow discussion in ticket 10159) so we would not need not change anything.
if it stays this way, truegallery will be broken with the next beta release of plone4

Added by Nathan Van Gheem on Mar 31, 2010 10:24 AM

Issue state: Unconfirmed → Confirmed

Responsible manager: (UNASSIGNED) → vangheem

The reason the adapter is using custom sizes for small and medium is because the default for those scales aren't want is desired. I'll fix this and make another release before the beta comes out.

Thanks for catching this.

Added by Harald Friessnegger on Mar 31, 2010 10:25 AM

if we cant't fix this by setting sizes manually eg:

  'large':{
      'width': 768,
      'height': 768,
  },

we need to defer the time the sizes are obtained so p.a.i sizes are available and use
plone.app.imaging.utils.getAllowedSizes or ImageField.getAllowedSizes() in order to be compatible with p.a.i

Added by Nathan Van Gheem on Mar 31, 2010 11:15 AM

Issue state: Confirmed → Resolved

fixed in the trunk. I will release soon.

Added by Harald Friessnegger on Apr 20, 2010 02:49 PM

Issue state: Resolved → Tested and confirmed closed

i tested trunk with plone4.0b2. works out fine, thx.
maybe you can do a new release when we're done with #24 and #25

Added by Nathan Van Gheem on Apr 20, 2010 03:13 PM

Yes, I think we should. Might be able to get to it during my lunch break even.

No responses can be added.