#70 — LinguaPlone doesn't allow manual editing of IDs

I have the same issue with latest Linguaplone 0.9. I must rename shortnames after creation of translation. It look like cool feature of plone "creation of shortname based on Title" overrides the Linguaplone shortname.

I have also confirmed this bug. Of significant note is that you don't even need to install LinguaPlone for this bug to manifest. Simply having LinguaPlone on the filesystem in the Products folder causes it as well. Hope this helps squash this bug.

LinguaPlones processForm methods calleds _renameAfterCreation without parameters, while Archetypes passes check_auto_id=True.

The only problem here is that LinguaPlones auto-ids bear no resemblance to Archetypes auto_ids, so it will always return that the object should be renamed. The fix is simple, but ugly, si I'm not gonna check it in before further discussion. It's simply to check if an id was set in the form or not. If it was, then we check if it should be renamed or not.

Here is an SVN-diff (made on the 1.0 branch).

Index: I18NBaseObject.py
===================================================================
--- I18NBaseObject.py (revision 16282)
+++ I18NBaseObject.py (working copy)
@@ -322,7 +322,8 @@
                 self.invalidateTranslations()
 
         if self._at_rename_after_creation and is_new_object:
- new_id = self._renameAfterCreation()
+ new_id = self._renameAfterCreation(
+ check_auto_id=not not self.REQUEST.form.get('id'))
 
         if shasattr(self, '_lp_default_page'):
             delattr(self, '_lp_default_page')

OK, pasting the diff in was a bad idea. Here it is a an attachement instead.

+1

http://www.nabble.com/custo[…]t-saved-tf4936915s6741.html

LinguaPlone 2.0

Plone 3.0.3
CMF-2.1.0
Zope (Zope 2.10.5-final, python 2.4.4, darwin)
Python 2.4.4 (#1, Nov 17 2007, 19:56:03) [GCC 4.0.1 (Apple Computer, Inc. build 5250)]
PIL 1.1.6

+1

http://www.nabble.com/custo[…]t-saved-tf4936915s6741.html

LinguaPlone 2.0

Plone 3.0.3
CMF-2.1.0
Zope (Zope 2.10.5-final, python 2.4.4, darwin)
Python 2.4.4 (#1, Nov 17 2007, 19:56:03) [GCC 4.0.1 (Apple Computer, Inc. build 5250)]
PIL 1.1.6

See also
http://plone.org/products/redirectiontool/issues/4
-- I'm not sure whether it's relevant but Justin Ryan (there) and I both had issues with apparently broken aliases, at some point, whilst uninstalling/removing/replacing/re-installing products (for troubleshooting purposes).

In my case I was juggling a few products, not only LinguaPlone and RedirectionTool -- so I'm not pointing a finger at either product; simply cross-referencing :-)

I don't know how common it is for site administrators to enable editing of short names but in our case:

 * the majority of content is enfolded (pages within folders)

 * some folders and their contents have extraordinarily long titles.

For example the titles of both this page
http://centrim.mis.brighton.ac.uk/[…]/overview
and its enclosing folder
http://centrim.mis.brighton.ac.uk/[…]/folder_contents
"Creating_games: Mapping and Upgrading Creative Processes for Sustained Innovation — The challenge facing UK Electronic Games Developers" - "Creating_games: Mapping and Upgrading Creative Processes for Sustained Innovation — The challenge facing UK Electronic Games Developers"
led to names that were in no way short :-)

So for us, short names are an important aspect.

I don't imagine that excess (unrequired) aliases have any impact on performance, but if they are a concern then Redirection Tool http://plone.org/products/redirectiontool may be useful.

Re
http://n2.nabble.com/Lingua[…]-Folders-ids-tp1075240.html

Two questions:

= 1) Applicability =

Is the patch as originally proposed by Lennart perfectly safe to use with Plone 3.1.5.1?

= 2) Timeline =

Can you estimate when the patch in some form will be included within LinguaPlone?

Thanks
Graham

I have applied Lennart's patch to my Plone 3.1.5.1 production server.

First test (adding a link with a custom short name): fine.

Discussing with Lennart in IRC…

I have a what I think is a cleaner patch for this.


348,349c348
< is_new_object = self.checkCreationFlag()
<
---
>
355,356c354
< if self._at_rename_after_creation and is_new_object:
< new_id = self._renameAfterCreation()
---
> new_id = self.getId()


Basically -- _renameAfterCreation() doesn't need to be called directly by I18NBaseObject:processForm(). Because BaseObject:processForm() is actually explicitly called just a few lines above, and it does the same thing, only it uses the 'check_auto_id=True' argument.

So -- it appears to me that I18NBaseObject:processForm() included two redundant calls at the top of the function implementation: checkCreationFlag() and _renameAfterCreation().

Removal of that eliminates the override of a user-supplied short name, which can be had easily via self.getId(), and the rest of processForm() can proceed as before.

I'm running this now and don't see any bad side effects, but I don't have any other LinguaPlone familiarity and so this should be reviewed by a core LinguaPlone developer to see if it makes sense.

Cheers.

This is fixed in LP trunk using the patch by David Hostetler. It will be released as part of LP 3.0b4.