#235 — Links broken with VHM when using _vh_ parts

by tixxit — last modified Mar 29, 2010 12:20 PM

State	Resolved
Version:	3.x
Area	Functionality
Issue type	Patch
Severity	Medium
Submitted by	tixxit
Submitted on	Feb 05, 2010
Responsible	—
Target release:	3.x

Return to tracker

Version: Revision 33699 from SVN trunk

The links don't work if you are using LinguaPlone with VHM with "_vh_" parts added on. LinguaPlone appends these (the _vh_ parts) to the URL before it adds set_language=...

Following how the other one is fixed, you can simply add one further check:

if check == 'VirtualHostRoot' or check.startswith('_vh_'):

And that should fix the problem. I've attached a patch that does exactly that.

Steps to reproduce:: 1. Set up Plone with LinguaPlone and access the site using VHM with a _vh_... part added to it. Example:
http://127.0.0.1:8080/[…]/apage
2. Link given for other languages looks like:
http://localhost/[…]/_vh_bar?set_language=XX

Attached:

lingua-plone-vhm-fix.patch — differences between files, 687 bytes

Added by Ramon Navarro Bosch on Mar 29, 2010 11:45 AM

I uploaded the code with a test (r35577 and r35578)

Added by Hanno Schlichting on Mar 29, 2010 12:20 PM

Issue state: Unconfirmed → Resolved

Target release: None → 3.x

Thanks, this will be fixed in the upcoming 3.1a2 release.

No responses can be added.