#41 — BadRequest Error if enclosure already exists

by Domen Kožar — last modified Dec 27, 2011 10:12 PM
State Resolved
Version:
—
Area Functionality
Issue type Bug
Severity Medium
Submitted by Domen Kožar
Submitted on Nov 25, 2011
Responsible Maurits van Rees
Target release: 2.0.7
Return to tracker
If enclosure already exists, invokeFactory will return BadRequest error since it expects unique id

Commit: https://github.com/[…]/9b674965f2328a0091b16f8c3dd0cdfba4026425
Added by Maurits van Rees on Dec 27, 2011 05:38 PM
Responsible manager: (UNASSIGNED) → maurits
That would be strange. When updating an existing feed item, feedfeeder calls the replaceItem method of the folder, which removes the existing item and adds a fresh one. This fresh one of course does not contain any enclosures.

Are you using any patches?

Or are you just guessing that this happens in theory? I got confused myself anyway, as I wondered during testing where the previous enclosure had gone. :-)
Added by Domen Kožar on Dec 27, 2011 08:27 PM
This only happened once and since it was on production, I didn't have time to investigate what exactly went wrong. Cronjob just started failing.

What was happening was that invokeFactory could not create enclosure. If I remember correctly this happened due to two posts having the same signature for enclosure. Is that possible to conflict?
Added by Maurits van Rees on Dec 27, 2011 10:00 PM
Issue state: Unconfirmed → Resolved
No, that works fine. I have just tested it.

But when one entry has two enclosures that have the same href, then this BadRequest error will occur.

Fixed in r247577.
Added by Domen Kožar on Dec 27, 2011 10:09 PM
Thanks!
Added by Maurits van Rees on Dec 27, 2011 10:12 PM
Target release: None → 2.0.7
2.0.7 has been released with this fix.

No responses can be added.