#34 — update_feed_items changes modification date of previously existing feed items

by Suresh V — last modified Dec 27, 2011 10:17 PM
State Resolved
Version: 2.0.2
Area Functionality
Issue type Bug
Severity Medium
Submitted by Suresh V
Submitted on Mar 08, 2011
Responsible Maurits van Rees
Target release: 2.0.4
Return to tracker
should not touch existing items. should bring only new items. worked ok in 2.0 (i think). will confirm.
Added by Maurits van Rees on Mar 08, 2011 05:09 PM
When an existing item has changed in the upstream feed it is fine to update the item, which then also changes the modification date.

When an upstream item has not changed, our feed item should also not change. If it does change, that is indeed a bug. Are you saying this is the case?
Added by Suresh V on Mar 09, 2011 09:39 AM
Not sure. May be a configuration option to not update existing items would be nice.
Added by Suresh V on Mar 09, 2011 09:46 AM
In utilities.py

---
151 else:
152 # Not new, not refreshed: let it be, laddy.
153 prev.setObjectInfo(entry.copy())
154 prev.reindexObject()
155 continue
---

reindexObject() will change modified. Why are we doing this?
Added by Maurits van Rees on Mar 24, 2011 09:54 AM
Issue state: Unconfirmed → Resolved
Responsible manager: (UNASSIGNED) → maurits
Indeed, it does not seem to make sense to do a reindexObject here. We could do portal_catalog.catalog_object(prev) here to only update the catalog, but nothing has changed.

In the tests we do have the situation that the entry has changed compared with the stored objectInfo. I now check this and save the new entry only when there is a difference. That still does not require a update to the catalog.

Fixed in r236370.

Released 2.0.4 with this fix.
Added by Maurits van Rees on Dec 27, 2011 10:17 PM
Target release: None → 2.0.4

No responses can be added.