#4 — Do not use IFileFactory interface

by jean-mat Grimaldi — last modified Apr 04, 2011 08:23 AM

State	Resolved
Version:	1.0.2
Area	Functionality
Issue type	Bug
Severity	Important
Submitted by	jean-mat Grimaldi
Submitted on	Oct 11, 2010
Responsible	—
Target release:	—

Return to tracker

in quickupload, the IfileFactory is adapted with a different call (more args in __call__). It's not a good practice, another product can use the old __call__ with 4 args.

A new factory must be defined IQuickUploadFileFactory

Added by jean-mat Grimaldi on Oct 11, 2010 04:21 PM

Issue state: Unconfirmed → Resolved

resolved on trunk

Added by Yuri on Apr 04, 2011 08:10 AM

I get:

2011-04-04T10:06:43 INFO collective.uploadify uploading file: filename=GruppoPortaleContenutiRiunione15marzo2011.pdf, content_type=application/pdf
------
2011-04-04T10:06:43 ERROR Zope.SiteErrorLog 1301904403.180.167642218533 http://xxx/collezioni_navigazione/cartella-servizi/test-article-yuri/@@upload_file
Traceback (innermost last):
  Module ZPublisher.Publish, line 127, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 47, in call_object
  Module collective.uploadify.browser.upload, line 146, in __call__
TypeError: __call__() takes exactly 6 arguments (4 given)

even on collective.quickupload 1.0.3, maybe something wrong?

Added by Yuri on Apr 04, 2011 08:23 AM

Sorry, I've found it. It is a conflict between collective.quickupload and collective.uploadify :-/

No responses can be added.