#2 — collective.blogging and plone.app.discussion, with a Folder enabled for blogging, throws errors

by andy nicholson last modified May 10, 2010 04:27 PM
State Confirmed
Version: 1.0b4
Area Functionality
Issue type Bug
Severity Medium
Submitted by andy nicholson
Submitted on Feb 03, 2010
Responsible Lukas Zdych
Target release: 1.0b4
On a Folder enabled for comments, then switch the Folder to be Blog enabled - gives the following error.


Traceback (innermost last):
  Module ZPublisher.Publish, line 119, in publish
  Module ZPublisher.mapply, line 88, in mapply
  Module ZPublisher.Publish, line 42, in call_object
  Module Products.Five.browser.metaconfigure, line 417, in __call__
  Module Shared.DC.Scripts.Bindings, line 313, in __call__
  Module Shared.DC.Scripts.Bindings, line 350, in _bindAndExec
  Module Products.PageTemplates.PageTemplateFile, line 129, in _exec
  Module Products.PageTemplates.PageTemplate, line 98, in pt_render
  Module zope.pagetemplate.pagetemplate, line 117, in pt_render
  Module zope.tal.talinterpreter, line 271, in __call__
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 891, in do_useMacro
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 536, in do_optTag_tal
  Module zope.tal.talinterpreter, line 521, in do_optTag
  Module zope.tal.talinterpreter, line 516, in no_tag
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 957, in do_defineSlot
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 536, in do_optTag_tal
  Module zope.tal.talinterpreter, line 521, in do_optTag
  Module zope.tal.talinterpreter, line 516, in no_tag
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 861, in do_defineMacro
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 957, in do_defineSlot
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 536, in do_optTag_tal
  Module zope.tal.talinterpreter, line 521, in do_optTag
  Module zope.tal.talinterpreter, line 516, in no_tag
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 949, in do_defineSlot
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 861, in do_defineMacro
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 586, in do_setLocal_tal
  Module zope.tales.tales, line 696, in evaluate
   - URL: index
   - Line 8, Column 12
   - Expression: <PathExpr nocall:'portal_discussion/isDiscussionAllowedFor'>
   - Names:
      {'container': <ATFolder at /culture/Members/andycat/my-new-blog-folder-2>,
       'context': <ATFolder at /culture/Members/andycat/my-new-blog-folder-2>,
       'default': <object object at 0x82538>,
       'here': <ATFolder at /culture/Members/andycat/my-new-blog-folder-2>,
       'loop': {},
       'nothing': None,
       'options': {'args': (<Products.Five.metaclass.SimpleViewClass from /Users/andycat/.buildout/eggs/collective.blogging-1.0b4-py2.4.egg/collective/blogging/browser/blogview.pt object at 0x7da0490>,)},
       'repeat': <Products.PageTemplates.Expressions.SafeMapping object at 0x7d9ee40>,
       'request': <HTTPRequest, URL=http://localhost:8080/[…]/view>,
       'root': <Application at >,
       'template': <ImplicitAcquirerWrapper object at 0x7da0750>,
       'traverse_subpath': [],
       'user': <PloneUser 'andycat'>,
       'view': <Products.Five.metaclass.SimpleViewClass from /Users/andycat/.buildout/eggs/collective.blogging-1.0b4-py2.4.egg/collective/blogging/browser/blogview.pt object at 0x7da0490>,
       'views': <zope.app.pagetemplate.viewpagetemplatefile.ViewMapper object at 0x7daf4b0>}
  Module zope.tales.expressions, line 217, in __call__
  Module Products.PageTemplates.Expressions, line 155, in _eval
  Module zope.tales.expressions, line 124, in _eval
  Module Products.PageTemplates.Expressions, line 102, in trustedBoboAwareZopeTraverse
  Module OFS.Traversable, line 284, in unrestrictedTraverse
   - __traceback_info__: ([], 'isDiscussionAllowedFor')
NotFound: isDiscussionAllowedFor
Steps to reproduce:
Install collective.blogging and plone.app.discussion (1.0b3)

Create a folder , mark it as "Blog enabled"
Added by andy nicholson on Feb 03, 2010 10:16 AM
This patch works for me:

15,17d14
< portal_discussion nocall:context/portal_discussion;
< isDiscussionAllowedFor nocall:portal_discussion/isDiscussionAllowedFor;
< getDiscussionFor nocall:portal_discussion/getDiscussionFor;
64c61
< talkback python:isDiscussionAllowedFor(item_object) and getDiscussionFor(item_object);
---
> talkback python:context.portal_discussion.isDiscussionAllowedFor(item_object) and context.portal_discussion.getDiscussionFor(item_object);


---

I presume nocall: isnt doing something correctly.. Im a little lost why it works :(
Added by andy nicholson on Feb 03, 2010 10:17 AM
Ah, sorry, the above is a patch for blogview.pt
Added by andy nicholson on Feb 04, 2010 04:35 AM
I take it back that the patch above works. Ignore it.
Added by Matt Hamilton on Mar 05, 2010 03:35 PM
I tried your patch, but no luck, I still get:

Module zope.tales.pythonexpr, line 59, in __call__
__traceback_info__: (context.portal_discussion.isDiscussionAllowedFor(item_object) and context.portal_discussion.getDiscussionFor(item_object))
Module <string>, line 0, in ?
AttributeError: isDiscussionAllowedFor

This is with p.a.d 1.0b3 and c.blogging 1.0rc2

-Matt
Added by Timo Stollenwerk on Mar 05, 2010 05:29 PM
portal_discussion/isDiscussionAllowedFor looks like a call of the old discussion tool. The p.a.discussion tool does not implement isDiscussionAllowedFor. I haven't implemented any BBB code for p.a.discussion yet.
Added by Lukas Zdych on Mar 16, 2010 08:59 AM
Issue state: UnconfirmedConfirmed
Responsible manager: (UNASSIGNED)lzdych
Target release: None1.0b4
Added by Davi Lima on May 10, 2010 04:16 PM
Maybe this has something to do with this recently released solution?

http://pypi.python.org/[…]/collective.discussionintegration.plonegazette
Added by Davi Lima on May 10, 2010 04:26 PM
This being the most interesting [changeset]:

http://dev.plone.org/[…]/collective.discussionintegration.plonegazette

No responses can be added.