#27 — "Diff from last" on earliest item

by Frank Bennett — last modified Mar 08, 2011 02:14 PM
State Resolved
Version: 1.0rc1
Area User interface
Issue type Bug
Severity Medium
Submitted by Frank Bennett
Submitted on Aug 03, 2006
Responsible Alec Mitchell
Target release: 1.0rc1
Return to tracker


There is an off-by-one error in whatever controls the appearance of the "Diff from last" link. It should appear on all but the first version; instead it appears on all but the most recent. If this is clicked against the earliest version, it throws an error.
Steps to reproduce:
Install CMFDiffTool
Install CMFEditions
Configure CMFDiffTool according to documentation
Create and save an ATCT page
Open the versions view and set the saved page as a version
Edit and save the page
Open the versions view and set the edited page as a version
Open versions view again and inspect the links
Click on the "Diff from last" link

Pow
Added by Gregoire Weber on Aug 04, 2006 01:56 PM
Target release: None → 1.0rc1
Responsible manager: (UNASSIGNED) → alecm
I'm so bold to assign this to alec :-)
Added by Frank Bennett on Aug 07, 2006 04:07 AM
This turned out to be easily fixed. In versions_history_form.pt, replace "start" with "end" in the tal:condition="not:repeat/vdata/start", and everything falls into place nicely.
Added by Frank Bennett on Aug 07, 2006 08:50 AM
Just noticed that this is the same as #25.
Added by Alec Mitchell on Aug 21, 2006 05:04 AM
Issue state: unconfirmed → resolved
Fixed in svn. Thanks for the fix and report.
Added by Mike Hammill on Mar 08, 2011 11:14 AM
I have a 3.3.5 site and version_history_form.pt appears to be correct, yet I still get this error. I have tried uninstalling iterate and re-installing it, but it still states:

This product has been upgraded. Old profile version was unknown. New profile version is 1.2.3. There is no upgrade procedure defined for this add-on. Please consult the product documentation for upgrade information, or contact the product author.

So what is the solution in this case? I don't get errors when an item has more than one version, but if there is only one, it still throws errors.
Added by Frank Bennett on Mar 08, 2011 02:14 PM
I wish I could help, but it's been years since I last worked with Plone, unfortunately.

No responses can be added.