#62 — CacheFu messes with plone_control_panel template

by Andy McKay — last modified Jan 08, 2009 02:19 PM

State	Rejected
Version:	1.0
Area	User interface
Issue type	Bug
Severity	Low
Submitted by	Andy McKay
Submitted on	Sep 05, 2006
Responsible	Ricardo Newbery
Target release:	1.0.2

Return to tracker

andym: cache_setup skin > prefs_main_template.pt overrides the prefs_main_template.pt that comes with Plone, removing css_slot and head_slot and hence breaking Clouseau
andym: any idea why its doing that?
bitmvnch: are those slots new in plone 2.5?
andym: they are present in 2.5, dunno if they are new
bitmvnch: hm.
bitmvnch: if they are new, that might be why.
bitmvnch: maybe that template just needs to be updated.

Added by Justin Ryan on Sep 05, 2006 11:13 PM

Severity: Low → Medium

Target release: 1.0.2 → None

Responsible manager: newbery → (UNASSIGNED)

andym: oddly the layer is called cache_prefs_plone20
[4:31PM] bitmvnch: well..
[4:31PM] bitmvnch: hm.
[4:31PM] • bitmvnch digs into portal_skins
[4:33PM] bitmvnch: hum, they are explicitly removed.
[4:33PM] bitmvnch: file an issue in cachefu, please. :)
[4:34PM] bitmvnch: well, i didn't compare to plone 2.0, only to plone 2.1 i guess..
[4:34PM] bitmvnch: i have never heard about that, so maybe those are rarely used slots.
[4:34PM] bitmvnch: i wonder if there is a reason that they are removed because they might change from what's in the cache..

Added by Sean Kelly on Nov 05, 2006 01:41 PM

I can always reproduce this. CacheFu's "CacheSetup" product includes a skin layer named "cache_prefs_plone20" that overrides Plone's prefs_main_template.pt. Why does it do this? The SVN log message merely states:

"Added patch from Fabiano Weimar dos Santos to make configlet work with Plone 2.0"

Removing cache_prefs_plone20 from the portal_skins layers for each skin seems to work around the problem just fine.

Added by Justin Ryan on Nov 05, 2006 05:21 PM

Issue state: unconfirmed → open

Target release: None → 1.0.2

Responsible manager: (UNASSIGNED) → justizin

It is necessary to override a couple of templates, differently for certain Plone versions, even. The installer should only add these skin layers in the appropriate version of Plone, but *maybe* a site upgraded from 2.0 to 2.1/5 would still have them. It's also possible that the installer is broken, or that it's check performs incorrectly in Plone 2.5.

I think going forward, that the install code should only enable skin layers for specific versions, never assuming that something will work going forward, which I am pretty sure is what this does.

I will look into this in the coming week.

Added by Justin Ryan on Nov 21, 2006 03:06 AM

Issue state: open → postponed

Severity: Medium → Important

There is a roadmap item up for discussion regarding this at:

http://plone.org/products/cachefu/roadmap/8

Putting this on hold until the fuip is implemented.

Added by Ricardo Newbery on Aug 16, 2007 12:26 AM

Issue state: postponed → open

This template no longer exists in 1.1. Probably not worth investigating to see if it's still a problem in 1.0.2

Added by Ricardo Newbery on Aug 16, 2007 12:28 AM

Issue state: open → rejected

Severity: Important → Low

Responsible manager: justizin → newbery

Closing ticket. Feel free to reopen, if Clouseau still needs to work with 1.0.2 and it doesn't.

No responses can be added.