#57 — Configlets broken after installing in Plone-2.5

by Myroslav Opyr — last modified Jan 08, 2009 02:18 PM
State Resolved
Version: 1.0.1
Area Functionality
Issue type Bug
Severity Important
Submitted by Myroslav Opyr
Submitted on Aug 29, 2006
Responsible Justin Ryan
Target release: 1.0.2
Return to tracker


Take closer look at: http://dev.plone.org/collective/changeset/23382

It has very weird logic, and installs broken (for Plone-2.5) cache_prefs_plone20 skin layer even if it overrides the one from Plone-2.5.

To workaround the issues, it is necessary to remove cache_prefs_plone20 layer from portal_skins properties after installation.
Steps to reproduce:
Install Plone-2.5
Install CacheFu in Plone-2.5 instance
See any configlet, it has broken DOM (multiple tags with same ID).
Added by Justin Ryan on Aug 29, 2006 07:17 PM
Issue state: unconfirmed → open
Target release: None → 1.0.2
Responsible manager: (UNASSIGNED) → justizin
Severity: Important → Medium
Interesting, I will look into this more closely, this code probably does need to take into account some different behaviour in Plone 2.5.

Thanks for hunting down a rev.
Added by Justin Ryan on Sep 05, 2006 09:05 PM
Issue state: postponed → open
Severity: Medium → Important
Myroslav - do you have a patch for this, perhaps? I'd like to address it in upcoming 1.0.2 release.
Added by Reinout van Rees on Dec 19, 2006 01:59 PM
From what I figured out, the logic that determines whether we're installing inside a 2.0 site is broken. Everything that's not 2.1 is considered to be 2.0. So also 2.5 is 2.0 as it is not 2.1.

I fixed this on a branch that rocky made once, but that lead to another error. But this should give a pointer.
Added by Justin Ryan on Dec 19, 2006 03:19 PM
I think this is addressed in:

  http://plone.org/products/cachefu/issues/72

Mind taking a look, reinout?
Added by Myroslav Opyr on Dec 19, 2006 03:29 PM
#72 patch doesn't fix the issue. We've created patch in September but failed to provide it here. We are preparing patch against fresh trunk checkout at the moment and expect to submit it here a bit later today.
Added by Myroslav Opyr on Dec 19, 2006 04:15 PM
The patch is attached. Review it, please and approve it or commit it yourself.
Added by Ricardo Newbery on Aug 15, 2007 10:28 PM
Issue state: open → resolved
Applied patch to 1.0 maintenance branch... http://dev.plone.org/collective/changeset/47348

And we're not supporting Plone 2.0 in the latest version now. Closing ticket.

No responses can be added.